codeant-ai-for-open-source[bot] commented on code in PR #41111:
URL: https://github.com/apache/superset/pull/41111#discussion_r3427584404
##########
superset-frontend/plugins/plugin-chart-echarts/src/types.ts:
##########
@@ -105,6 +106,12 @@ export type LegendFormData = {
export type EventHandlers = Record<string, { (props: any): void }>;
+export type QueryEventHandlers = {
+ name: string;
+ query: string;
+ handler: (props: any) => void;
Review Comment:
**Suggestion:** Replace the `any` handler argument with a concrete ECharts
event payload type (or a constrained reusable interface/generic) so the new
query event handler API is strongly typed. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The modified TypeScript file introduces a new `any` usage in the added
`QueryEventHandlers` type. This directly violates the rule that new or modified
TypeScript/TSX code must not use `any`; a concrete event type or narrower
generic should be used instead.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=8e6483cac29f4069a30170587154df97&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=8e6483cac29f4069a30170587154df97&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/plugins/plugin-chart-echarts/src/types.ts
**Line:** 112:112
**Comment:**
*Custom Rule: Replace the `any` handler argument with a concrete
ECharts event payload type (or a constrained reusable interface/generic) so the
new query event handler API is strongly typed.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41111&comment_hash=661eff3691e3c724259ab30db47b3552c551f819bb8b68cd18b62e8c3819a685&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41111&comment_hash=661eff3691e3c724259ab30db47b3552c551f819bb8b68cd18b62e8c3819a685&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
