rusackas commented on PR #35208: URL: https://github.com/apache/superset/pull/35208#issuecomment-4732502241
The `ownState` threading looks right, but `pre-commit` is failing — prettier wants to reformat the new `useCallback` in `ViewQueryModal.tsx` (the function arg and dep array need wrapping). Run `pre-commit run --all-files` (or `npx prettier --write` on that file) and push, then CI should go green. While you're in there, mind adding a quick `ViewQueryModal.test.tsx` case asserting `ownState` is passed to `getChartDataRequest`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
