rusackas commented on PR #35208: URL: https://github.com/apache/superset/pull/35208#issuecomment-4746878953
Still red on `pre-commit` here, @marunrun - the `useCallback` in `ViewQueryModal.tsx` needs the prettier reformat I mentioned. `npx prettier --write` on that file and push should clear it. Any luck adding a `ViewQueryModal.test.tsx` case asserting `ownState` reaches `getChartDataRequest`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
