rusackas commented on PR #40803:
URL: https://github.com/apache/superset/pull/40803#issuecomment-4732513584

   wo things before this can go in @Keonik1:
   
   - Needs a `Chart.yaml` version bump (and the README badge) or `ct lint` will 
reject it.
   - The three new values land in three different shapes: 
`secretEnv.annotations`, top-level `secretConfigAnnotations`, and 
`supersetWebsockets.configAnnotations`. Can we make them consistent? Nesting 
under the relevant block (e.g. `secretEnv.annotations`) reads cleaner than a 
top-level `secretConfigAnnotations`.
   
   Updating the branch to re-run CI in the current state of affairs there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to