rusackas commented on PR #35459: URL: https://github.com/apache/superset/pull/35459#issuecomment-4732506063
@SBIN2010 picking this back up — the points from my last pass are still open (the redundant `half` boolean + dual padding path, snake/camel control-name mismatch, copy-pasted gauge descriptions, angle clamping, a test). On top of that `lint-frontend` is now red on a trivial one: `transformProps.ts:430` `startAngle: startAngle` trips `object-shorthand`, just write `startAngle`. Want to push a rebase + those fixes and re-ping me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
