rusackas commented on PR #40435:
URL: https://github.com/apache/superset/pull/40435#issuecomment-4732614875
A couple of things before this can land @kasiazjc:
It needs a rebase first - currently conflicting with `master`.
The bigger thing: it looks like the `.po` files got edited by hand here, so
we end up with both the old `COPY QUERY`/`FIT DATA` msgids and the new `Copy
query`/`Fit data` ones, and `babel-extract` is red. I think the only source
edits should be the component strings, then
`./scripts/translations/babel_update.sh` regenerates `messages.pot` and merges
into each `.po` - editing them directly drifts from what extraction produces.
Can you run that and drop the manual `.po` changes?
Also worth a look at @aminghadersohi's note on the redundant cast in
`chartAction.ts`, and `t('Ok')` in `ResultSet` - we already have an `OK` key,
so that one's probably better left as-is to avoid splitting the translation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
