rusackas commented on code in PR #39535:
URL: https://github.com/apache/superset/pull/39535#discussion_r3430734599
##########
superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx:
##########
@@ -34,6 +34,8 @@ import { t } from '@apache-superset/core/translation';
import { ensureIsArray, formatNumber, usePrevious } from '@superset-ui/core';
import { Constants } from '@superset-ui/core/components';
import {
+ BaseOptionType,
+ DefaultOptionType,
Review Comment:
These `antd/es/select` imports already live in this wrapper file on master —
the PR just adds a couple of type names to the existing line.
`superset-ui-core` is the wrapper layer, so it legitimately pulls antd types
directly here. Not expanding the surface.
##########
superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.tsx:
##########
@@ -38,6 +39,8 @@ import {
getClientErrorObject,
} from '@superset-ui/core';
import {
+ BaseOptionType,
+ DefaultOptionType,
Review Comment:
Same as the Select.tsx one — `antd/es/select` is already imported here on
master and this file is part of the wrapper layer itself, so the antd types
belong. The PR only adds names to the existing import.
##########
superset-frontend/packages/superset-ui-core/src/components/TableCollection/index.tsx:
##########
@@ -27,7 +27,12 @@ import {
} from 'react-table';
import { styled } from '@apache-superset/core/theme';
import { Table, TableSize } from '@superset-ui/core/components/Table';
-import { TableRowSelection, SorterResult } from 'antd/es/table/interface';
+import {
+ ColumnsType,
+ TableRowSelection,
+ SorterResult,
+} from 'antd/es/table/interface';
Review Comment:
`antd/es/table/interface` is already imported on master here — the PR just
adds `ColumnsType`. This is the TableCollection wrapper, so the antd table
types are needed directly; the `Table` wrapper does not re-export them.
##########
superset-frontend/packages/superset-ui-core/src/components/TableCollection/index.tsx:
##########
@@ -27,7 +27,12 @@ import {
} from 'react-table';
import { styled } from '@apache-superset/core/theme';
import { Table, TableSize } from '@superset-ui/core/components/Table';
-import { TableRowSelection, SorterResult } from 'antd/es/table/interface';
+import {
+ ColumnsType,
+ TableRowSelection,
+ SorterResult,
+} from 'antd/es/table/interface';
+import type { TableProps } from 'antd/es/table';
Review Comment:
Same file/same reason as the line above — `TableProps` comes from
`antd/es/table` because this wrapper types its own props against antd directly,
and the `Table` wrapper does not re-export that type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
