codeant-ai-for-open-source[bot] commented on code in PR #39535:
URL: https://github.com/apache/superset/pull/39535#discussion_r3430737867
##########
superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.tsx:
##########
@@ -38,6 +39,8 @@ import {
getClientErrorObject,
} from '@superset-ui/core';
import {
+ BaseOptionType,
+ DefaultOptionType,
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag direct `antd` type imports in the `Select` wrapper layer;
these files are allowed to use `antd` types when they are part of the wrapper
implementation itself.
**Applied to:**
- `superset-frontend/packages/superset-ui-core/src/components/Select/**`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
##########
superset-frontend/packages/superset-ui-core/src/components/TableCollection/index.tsx:
##########
@@ -27,7 +27,12 @@ import {
} from 'react-table';
import { styled } from '@apache-superset/core/theme';
import { Table, TableSize } from '@superset-ui/core/components/Table';
-import { TableRowSelection, SorterResult } from 'antd/es/table/interface';
+import {
+ ColumnsType,
+ TableRowSelection,
+ SorterResult,
+} from 'antd/es/table/interface';
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Allow direct `antd` table type imports in TableCollection wrapper code
when the Superset `Table` wrapper does not re-export the needed types.
**Applied to:**
-
`superset-frontend/packages/superset-ui-core/src/components/TableCollection/**`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
##########
superset-frontend/packages/superset-ui-core/src/components/TableCollection/index.tsx:
##########
@@ -27,7 +27,12 @@ import {
} from 'react-table';
import { styled } from '@apache-superset/core/theme';
import { Table, TableSize } from '@superset-ui/core/components/Table';
-import { TableRowSelection, SorterResult } from 'antd/es/table/interface';
+import {
+ ColumnsType,
+ TableRowSelection,
+ SorterResult,
+} from 'antd/es/table/interface';
+import type { TableProps } from 'antd/es/table';
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag the direct `antd/es/table` type import for `TableProps` in
`superset-frontend/packages/superset-ui-core/src/components/TableCollection/index.tsx`;
this wrapper types its own props directly against Ant Design and the `Table`
wrapper does not re-export that type.
**Applied to:**
-
`superset-frontend/packages/superset-ui-core/src/components/TableCollection/index.tsx`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
