arpitjain099 commented on PR #40069: URL: https://github.com/apache/superset/pull/40069#issuecomment-4738092458
> Thanks for chasing this down @arpitjain099, but it looks like master beat us to it — release.yml, superset-docs-deploy.yml and superset-docs-verify.yml all already declare permissions: contents: read now (release even has the job-level contents: write on the publish step). That's why check-yaml is red on CI. Rebasing this gives a duplicate permissions: key. > > The one thing not on master is the actions: read you added to the docs workflows — do those actually need it for the artifact download, or are they passing fine on master without it? If they need it I'd happily take a tiny PR adding just that line; otherwise I think we can close this one. Thoughts? Thanks @rusackas . You are very kind! Yes definitely, I'd submit a PR today. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
