arpitjain099 commented on PR #40069: URL: https://github.com/apache/superset/pull/40069#issuecomment-4742168659
You are right, master got there first. I dug into the one open question (the `actions: read` on the docs workflows) and they do not need it. The case that would normally want `actions: read` is the cross-run artifact download in `superset-docs-deploy.yml`, which uses `dawidd6/action-download-artifact` with `run_id: github.event.workflow_run.id`. But the most recent `workflow_run`-triggered deploy on master ([run 27748028044](https://github.com/apache/superset/actions/runs/27748028044)) actually ran that "Download database diagnostics" step and it succeeded with just `contents: read`. Since superset is a public repo, reading another run's artifacts does not need the extra scope. `superset-docs-verify.yml` does the same download the same way, so same result. So there is nothing left here that master does not already have. Closing this out, thanks for the quick look! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
