codeant-ai-for-open-source[bot] commented on code in PR #40769:
URL: https://github.com/apache/superset/pull/40769#discussion_r3435313375
##########
tests/integration_tests/core_tests.py:
##########
@@ -937,6 +938,36 @@ def test_dashboard_permalink_native_filters_encoded(
parsed = parse_qs(urlsplit(location).query)
assert parsed["native_filters"] == [native_filters_value]
+ @mock.patch(
+
"superset.commands.dashboard.permalink.get.GetDashboardPermalinkCommand.run"
+ )
+ def test_dashboard_permalink_redirects_anonymous_access_denied(
+ self,
+ get_dashboard_permalink_mock,
+ ):
Review Comment:
**Suggestion:** Add explicit type annotations to this new test method
signature, including the patched mock argument type and a `-> None` return
type. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is a newly added Python test method and it omits type hints for the
patched mock argument as well as the return type.
The rule requires new Python functions/methods to be fully typed, so this is
a real violation.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b976441773eb4a9c97c288b7f2b2cfc6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b976441773eb4a9c97c288b7f2b2cfc6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/integration_tests/core_tests.py
**Line:** 944:947
**Comment:**
*Custom Rule: Add explicit type annotations to this new test method
signature, including the patched mock argument type and a `-> None` return type.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40769&comment_hash=941dac69277e93a982a337d0dabb5f8037af1252035b54a53620a0a4ddb32d40&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40769&comment_hash=941dac69277e93a982a337d0dabb5f8037af1252035b54a53620a0a4ddb32d40&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
