dmunozv04 commented on code in PR #40769:
URL: https://github.com/apache/superset/pull/40769#discussion_r3466985258
##########
superset/views/core.py:
##########
@@ -853,7 +853,11 @@ def dashboard_permalink(
) -> FlaskResponse:
try:
value = GetDashboardPermalinkCommand(key).run()
- except (DashboardPermalinkGetFailedError, DashboardAccessDeniedError)
as ex:
+ except DashboardAccessDeniedError as ex:
+ if not get_current_user():
+ return redirect_to_login()
+ return json_error_response(__("Error: %(msg)s", msg=ex.message),
status=404)
Review Comment:
This was pre-existing behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
