bito-code-review[bot] commented on PR #41200:
URL: https://github.com/apache/superset/pull/41200#issuecomment-4743189486
<!-- Bito Reply -->
The flagged issue is correct. The `Slice.clone` method (which is not visible
in the provided diff but is referenced in the reproduction steps) needs to be
updated to include the `extra` field in the dictionary of attributes copied
from the source slice to the new slice.
To resolve this, locate the `clone` method in `superset/models/slice.py` and
add `extra` to the attributes being copied:
```python
# In superset/models/slice.py, inside the clone() method:
new_slice = Slice(
slice_name=self.slice_name,
# ... existing fields ...
extra=self.extra,
# ...
)
```
There are no other comments on this PR to address.
**superset/models/slice.py**
```
new_slice = Slice(
slice_name=self.slice_name,
# ... existing fields ...
extra=self.extra,
# ...
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
