bito-code-review[bot] commented on PR #41204:
URL: https://github.com/apache/superset/pull/41204#issuecomment-4743925162
<!-- Bito Reply -->
The suggestion to add an explicit return type hint to the newly added test
method is correct, as it improves code clarity and adheres to type-checking
standards. You can resolve this by adding `-> None:` to the method signature.
Here is the corrected code for the test method:
```python
def test_deprecated_groupby_renamed_to_columns(
self,
query_object_factory: QueryObjectFactory,
raw_query_context: dict[str, Any],
) -> None:
"""groupby in stored query_context should be silently renamed to
columns."""
```
There are no other comments on this pull request to address.
**tests/unit_tests/common/test_query_object_factory.py**
```
def test_deprecated_groupby_renamed_to_columns(
self,
query_object_factory: QueryObjectFactory,
raw_query_context: dict[str, Any],
) -> None:
"""groupby in stored query_context should be silently renamed to
columns."""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
