codeant-ai-for-open-source[bot] commented on code in PR #41204:
URL: https://github.com/apache/superset/pull/41204#discussion_r3437318650
##########
tests/unit_tests/common/test_query_object_factory.py:
##########
@@ -138,3 +138,32 @@ def test_query_context_metric_names(
**raw_query_object,
)
assert query_object.metric_names == ["SUM", "num_girls", "num_boys"]
+
+ def test_deprecated_groupby_renamed_to_columns(
+ self,
+ query_object_factory: QueryObjectFactory,
+ raw_query_context: dict[str, Any],
+ ):
Review Comment:
**Suggestion:** Add an explicit return type hint to this newly added test
method so it is fully typed. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is a newly added Python test method, and it omits an explicit return
type annotation. The surrounding code was changed, so the rule requiring new
Python functions/classes to be fully typed applies here.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=e8d90e6921394345ad346a26edb92baa&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=e8d90e6921394345ad346a26edb92baa&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/common/test_query_object_factory.py
**Line:** 142:146
**Comment:**
*Custom Rule: Add an explicit return type hint to this newly added test
method so it is fully typed.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41204&comment_hash=d892ea46bc2b8ac7760663ec2ab4d69f1d32d0e67f51a00ebaf2dbcbb93219c8&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41204&comment_hash=d892ea46bc2b8ac7760663ec2ab4d69f1d32d0e67f51a00ebaf2dbcbb93219c8&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
