bito-code-review[bot] commented on PR #41206:
URL: https://github.com/apache/superset/pull/41206#issuecomment-4744673242
<!-- Bito Reply -->
The flagged issue is correct. Migrating the script to TypeScript is
recommended to improve type safety and maintainability, especially as new logic
is added.
To resolve this, you can rename
`superset-embedded-sdk/release-if-necessary.js` to
`superset-embedded-sdk/release-if-necessary.ts` and update the corresponding
build or package scripts to use `ts-node` or a similar runner.
Since there are no other comments in this pull request, there are no
additional items to address.
**superset-embedded-sdk/release-if-necessary.ts**
```
// Rename the file to .ts and update imports/types as needed.
// Example: Add type annotations for the execSync error object.
if (err.stdout) console.error(String(err.stdout));
if (err.stderr) console.error(String(err.stderr));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
