rusackas commented on code in PR #41206:
URL: https://github.com/apache/superset/pull/41206#discussion_r3438224426
##########
superset-embedded-sdk/release-if-necessary.js:
##########
@@ -47,7 +47,11 @@ function logError(...args) {
execSync('npm publish --access public', { stdio: 'pipe' });
log(`published ${version} to npm`);
} catch (err) {
- console.error(String(err.stdout));
+ // npm writes failure details to stderr (auth/permission/registry
+ // errors in particular), so surface both streams to avoid masking
+ // the real cause in CI logs.
+ if (err.stdout) console.error(String(err.stdout));
+ if (err.stderr) console.error(String(err.stderr));
Review Comment:
This PR just surfaces npm publish stderr; converting the whole release
script to TS is a separate refactor, out of scope here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
