marunrun commented on code in PR #35208:
URL: https://github.com/apache/superset/pull/35208#discussion_r3472615840
##########
superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/index.tsx:
##########
@@ -1018,6 +1018,7 @@ export const useExploreAdditionalActionsMenu = (
modalBody={
<ViewQueryModal
latestQueryFormData={latestQueryFormData as QueryFormData}
+ ownState={ownState}
Review Comment:
Good catch — fixed in c8da7e6e81. `ViewQueryModal` now strips `clientView`
with `omit(ownState, ['clientView'])` before calling `getChartDataRequest`,
matching the existing chart query path in `ExploreViewContainer`
(`omit(dataMask[slice_id]?.ownState, ['clientView'])`) and `Dashboard`'s
`activeAllDashboardFilters`. Added a test asserting `clientView` is removed
while `searchText`/`order_by` are preserved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
