Copilot commented on code in PR #41214:
URL: https://github.com/apache/superset/pull/41214#discussion_r3439579417
##########
superset/charts/data/dashboard_filter_context.py:
##########
@@ -107,8 +98,7 @@ def _is_filter_in_scope_for_chart(
# If the chart doesn't exist in the dashboard layout, treat it as a
# root-level chart.
- else:
- return "ROOT_ID" in root_path
+ return "ROOT_ID" in root_path
Review Comment:
`_is_filter_in_scope_for_chart` now ignores `chartsInScope` unconditionally,
but some call sites/fixtures (and potentially older dashboard metadata) provide
`chartsInScope` without a `scope` object. In that case `rootPath` defaults to
`[]` and the filter becomes out-of-scope for every chart, which is a behavioral
regression unrelated to the “stale cache” fix. Consider using `chartsInScope`
only as a backwards-compatibility fallback when `scope` is missing or not a
dict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
