rusackas commented on PR #41214: URL: https://github.com/apache/superset/pull/41214#issuecomment-4752984931
Thanks @Vitor-Avila, ths all seems sensible, but `unit-tests` ned some love. Those fixtures have `chartsInScope` but no `scope`/layout, so once we stop honoring `chartsInScope` the filter falls through to `"ROOT_ID" in []` and gets dropped. Is that just stale test data, or do real configs ever ship `chartsInScope` without a usable `scope.rootPath`? Want to make sure we're not silently dropping filters in the MCP path before this goes in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
