rusackas commented on PR #38096: URL: https://github.com/apache/superset/pull/38096#issuecomment-4747258162
@lucapazz I think #39710 beat us to this one. It landed on `master` back in May and fixes the same double-origin export bug by building the legacy URL with `includeAppRoot: false` (see `exportChart` in `exploreUtils/index.ts`), plus it added the regression tests. On current `master` the URL never carries an origin, so the `.replace(/^https?:\/\/[^/]+/, '')` here wouldn't have anything to strip. Can you check whether #37896 still repros for you on latest `master`? If it's resolved I'll close this out, but happy to reopen if you're still hitting the 404. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
