rusackas commented on PR #38835:
URL: https://github.com/apache/superset/pull/38835#issuecomment-4747258350
@Krishnachaitanyakc I think this produces the wrong escape for BigQuery. The
query in #35857 that fails is `IN ('Armando''s')` — already doubled single
quotes — and BigQuery rejects it with "concatenated string literals must be
separated by whitespace", because it reads `'Armando''s'` as `'Armando'` next
to `'s'`. BigQuery escapes a quote with a backslash (`'O\'Brien'`), not by
doubling. So `_process_string_literal` returning `'O''Brien'` reproduces the
reported error rather than fixing it. The unit tests pass only because they
assert the string shape, not that BigQuery accepts it. Am I reading the issue
wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
