rusackas commented on PR #38347: URL: https://github.com/apache/superset/pull/38347#issuecomment-4747830563
@vikash7485 this needs a rebase on current `master`, as both `charts/api.py` and `dashboards/api.py` have changed quite a bit since you branched. Also, the `TestMutationEndpointAuditIds` tests wrap a local `endpoint` fn rather than hitting the real `post`/`bulk_delete` routes, so they're really re-testing the existing `add_extra_log_payload` plumbing. Your DB-level assertions in the api_tests cover put/delete nicely - could the create/bulk paths get the same treatment so the regression is properly pinned down? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
