Copilot commented on code in PR #41194:
URL: https://github.com/apache/superset/pull/41194#discussion_r3440354972
##########
superset-frontend/src/explore/components/controls/ColumnConfigControl/constants.tsx:
##########
@@ -62,6 +62,7 @@ const d3NumberFormat: ControlFormItemSpec<'Select'> = {
const d3TimeFormat: ControlFormItemSpec<'Select'> = {
controlType: 'Select',
+ allowNewOptions: true,
label: t('D3 format'),
Review Comment:
New behavior (free-text entry) is introduced for `d3TimeFormat` by enabling
`allowNewOptions`, but there is no unit test coverage for this setting even
though this folder already has `ColumnConfigConstants.test.tsx` covering
`d3NumberFormat`. Adding a small test asserting
`SHARED_COLUMN_CONFIG_PROPS.d3TimeFormat.allowNewOptions === true` (and/or that
it remains unset/false when not intended) would help prevent regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
