bito-code-review[bot] commented on PR #41194:
URL: https://github.com/apache/superset/pull/41194#issuecomment-4748642316
<!-- Bito Reply -->
The suggestion to add unit test coverage for `d3TimeFormat.allowNewOptions`
is appropriate. Since this configuration change enables free-text entry,
verifying its state in `ColumnConfigConstants.test.tsx` ensures the expected
behavior is maintained and helps prevent future regressions, consistent with
existing tests for `d3NumberFormat`.
**superset-frontend/src/explore/components/controls/ColumnConfigControl/constants.tsx**
```
const d3TimeFormat: ControlFormItemSpec<'Select'> = {
controlType: 'Select',
+ allowNewOptions: true,
label: t('D3 format'),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
