bito-code-review[bot] commented on code in PR #41222:
URL: https://github.com/apache/superset/pull/41222#discussion_r3440502030
##########
docs/admin_docs/configuration/configuring-superset.mdx:
##########
@@ -455,6 +455,51 @@ def FLASK_APP_MUTATOR(app: Flask) -> None:
app.before_request_funcs.setdefault(None,
[]).append(make_session_permanent)
```
+## Customizing the landing page (index view)
+
+The page served at `/` is rendered by an index view. By default Superset
registers
+`SupersetIndexView`, which redirects to `/superset/welcome/` and also adds the
+`/lang/<locale>` locale handler. You can replace it with your own view, for
example
+to send users straight to a specific dashboard or to a chart list.
+
+Set `FAB_INDEX_VIEW` to the **importable dotted path** of your view class.
Flask-AppBuilder
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Documentation describes unimplemented feature</b></div>
<div id="fix">
The documentation presents FAB_INDEX_VIEW as the mechanism to customize the
landing page, but Superset's `configure_fab()` at
`superset/initialization/__init__.py:937` hard-codes `appbuilder.indexview =
SupersetIndexView` with no code path that reads `FAB_INDEX_VIEW`. Users
following this guide will set the config and get no result. The fix belongs in
configure_fab(), not in this documentation — add a check like `fab_index_view =
self.config.get("FAB_INDEX_VIEW")` before assigning the hard-coded value.
</div>
</div>
<small><i>Code Review Run #f89051</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
