bito-code-review[bot] commented on code in PR #41222:
URL: https://github.com/apache/superset/pull/41222#discussion_r3440766833
##########
docs/admin_docs/configuration/configuring-superset.mdx:
##########
@@ -455,6 +455,51 @@ def FLASK_APP_MUTATOR(app: Flask) -> None:
app.before_request_funcs.setdefault(None,
[]).append(make_session_permanent)
```
+## Customizing the landing page (index view)
+
+The page served at `/` is rendered by an index view. By default Superset
registers
+`SupersetIndexView`, which redirects to `/superset/welcome/` and also adds the
+`/lang/<locale>` locale handler. You can replace it with your own view, for
example
+to send users straight to a specific dashboard or to a chart list.
+
+Set `FAB_INDEX_VIEW` to the **importable dotted path** of your view class.
Flask-AppBuilder
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion is based on the assumption that `FAB_INDEX_VIEW`
is not being utilized by Superset. However, as you noted, Flask-AppBuilder's
`init_app()` method handles the `FAB_INDEX_VIEW` configuration internally after
the initial setup. Since the configuration is correctly processed by the
underlying framework, the documentation is accurate as written and no code
changes are required in `configure_fab()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
