rusackas commented on PR #39528: URL: https://github.com/apache/superset/pull/39528#issuecomment-4748916226
Thanks @guptapuja, the fix itself seems right, but some things from my last pass are still open so we can't merge as-is. `pre-commit` is still red - the diff has a mis-indented `handleRefreshActivity` body and a stray blank line in `ChartTable.tsx`, plus trailing whitespace on the new prop in `types.ts`. Mind running `pre-commit` and pushing the reformat? Still no test covering the new callback / `refreshKey` bump, and `ChartTable` wraps `refreshData` in `handleRefreshData` while `DashboardTable` calls `onActivityRefresh?.()` directly - would be nice to land on one pattern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
