codeant-ai-for-open-source[bot] commented on code in PR #41250:
URL: https://github.com/apache/superset/pull/41250#discussion_r3443836839
##########
tests/unit_tests/utils/webdriver_test.py:
##########
@@ -273,6 +273,34 @@ def test_empty_webdriver_config(self, mock_chrome,
mock_app_patch, mock_app):
# Should create driver without errors
mock_driver_class.assert_called_once()
+ @patch("superset.utils.webdriver.app")
+ def test_driver_sets_page_load_timeout(self, mock_app_patch):
Review Comment:
**Suggestion:** Add full type hints to this newly added test method
signature, including the patched argument type and an explicit `-> None` return
annotation. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is a newly added Python test method in the modified file, and its
signature omits type hints for the parameter and the return type. The custom
rule requires new Python code to be fully typed, so this is a real violation.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=8cef857e5244494089f0ea82f461084d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=8cef857e5244494089f0ea82f461084d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/utils/webdriver_test.py
**Line:** 276:277
**Comment:**
*Custom Rule: Add full type hints to this newly added test method
signature, including the patched argument type and an explicit `-> None` return
annotation.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41250&comment_hash=ca5f7c9b77cc65be399bc15ce405f602b0b796c5aa93bb0ebfd3c338d6774747&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41250&comment_hash=ca5f7c9b77cc65be399bc15ce405f602b0b796c5aa93bb0ebfd3c338d6774747&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
