rusackas commented on PR #41250: URL: https://github.com/apache/superset/pull/41250#issuecomment-4779363926
@aminghadersohi thanks for the careful pass. Knocked out the nits: `ALERT_REPORTS_CSV_REQUEST_TIMEOUT` is just `60` now, the csv test stubs use `float | None` to match the real signature, and I left a note that the `SMTP_TIMEOUT` fallback in `core.py` needs to stay in sync with the `config.py` default. On the Slack and webhook knobs (MEDIUM-1/2) — both are already bounded at 30s/60s, so this PColumns's "can't hang forever" goal is met. I'm inclined to leave making those operator-tunable for a follow-up rather than widen this one... but if you feel strongly they belong here I can add them. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
