rusackas commented on PR #40180: URL: https://github.com/apache/superset/pull/40180#issuecomment-4753642004
Thanks @Elengar, the approach here looks solid and the test coverage across BigQuery/ClickHouse/Postgres is great. I'll tackle the rebase so CI re-runs. One thing I want your read on before we land it: `handle_temporal_value` now coerces any all-digit string (`re.fullmatch(r"[+-]?\d+", value)`) on a temporal column for `==`/`IN`/`>`/etc., where before only `float`/`int` got coerced. Is there a risk of a legit digit-string value (say a year like `"2024"` stored against a temporal col) getting silently reinterpreted as epoch-ms? Or is the temporal-column guard tight enough that this can't happen in practice? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
