Elengar commented on PR #40180: URL: https://github.com/apache/superset/pull/40180#issuecomment-4756102047
It might have worked before in some specific cases, but it is extremely unstable behaviour anyway: 1. Works only on some DBs like MySQL (non-strict mode), DuckDB, SQLite that allow comparisons like date_col >= '2024', while cause an error on most OLAP DBs. 2. Before the changes, the string '2024' might pass through as-is, but 2024 (int) or 2024.0 (float) were already silently coerced to 2ms 3. Can only happen on misconfigured/stale dataset configurations, or on calculated columns with weird explicit cast to string like CAST(EXTRACT(YEAR FROM date_col) AS STRING), which also causes broken sorting, so I'm not sure why anyone would want to do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
