durgaprasadml commented on PR #40935: URL: https://github.com/apache/superset/pull/40935#issuecomment-4756706281
> The `schemas.py` refactor drops `CreateDatasetRequest` entirely, but `create_dataset.py` still imports it (line 39) — so mypy fails and ~30 MCP test modules error out at collection. Can you restore `CreateDatasetRequest` alongside the new `CreateDatasetMetric`/`CreateDatasetCalculatedColumn` classes? Also curious why the `.github/actions/setup-docker` and `github-action-validator.yml` changes ride along here — they seem unrelated to the MCP work. Thanks for pointing that out. I’ve restored CreateDatasetRequest and removed the unrelated CI workflow changes from this PR so the scope remains focused on the MCP virtual dataset metrics and adhoc SQL metric improvements. The workflow changes were introduced while investigating CI failures during development, but I agree they are unrelated to the MCP functionality and don’t belong in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
