durgaprasadml commented on PR #40935: URL: https://github.com/apache/superset/pull/40935#issuecomment-4761727992
Thanks for catching that edge case. I’ve updated _update_virtual_dataset() so that all update-phase failures, including DatasetInvalidError, are now routed through DatasetUpdateFailedError after cleanup. This ensures callers consistently receive the rollback-aware error path and don’t see a validation message that obscures the fact that the dataset was created and subsequently cleaned up. I also added coverage for the DatasetInvalidError update-path in test_create_virtual_dataset_update_failure_rollback, verifying both cleanup behavior and the "creation rolled back" response message. Changes are included in commit 4c74cea. All checks are passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
