codeant-ai-for-open-source[bot] commented on code in PR #41252: URL: https://github.com/apache/superset/pull/41252#discussion_r3445596825
########## superset-frontend/src/dashboard/reducers/undoableDashboardLayout.test.ts: ########## @@ -0,0 +1,154 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { ActionCreators } from 'redux-undo'; + +import undoableLayoutReducer from 'src/dashboard/reducers/undoableDashboardLayout'; +import { UPDATE_COMPONENTS } from 'src/dashboard/actions/dashboardLayout'; +import { HYDRATE_DASHBOARD } from 'src/dashboard/actions/hydrate'; +import { + DASHBOARD_ROOT_ID, + DASHBOARD_GRID_ID, + DASHBOARD_HEADER_ID, +} from 'src/dashboard/util/constants'; +import { + DASHBOARD_ROOT_TYPE, + DASHBOARD_GRID_TYPE, + DASHBOARD_HEADER_TYPE, + CHART_TYPE, +} from 'src/dashboard/util/componentTypes'; + +// Cast reducer to accept partial mock data and inspect history fields in tests +const reducer = undoableLayoutReducer as (state: any, action: any) => any; Review Comment: **Suggestion:** Replace the reducer cast that uses `any` with concrete reducer-derived types (for state, action, and return) so the test keeps type safety without broad `any` usage. [custom_rule] **Severity Level:** Minor ⚠️ <details> <summary><b>Why it matters? 🤔 </b></summary> The file is TypeScript and the cast explicitly uses `any` for both the reducer state and action parameters, which violates the custom rule against new or modified TS/TSX code using `any`. The suggestion correctly identifies a real rule violation in the current file. </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=96364ff316964c60afd9e4e84e8351c4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=96364ff316964c60afd9e4e84e8351c4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset-frontend/src/dashboard/reducers/undoableDashboardLayout.test.ts **Line:** 37:37 **Comment:** *Custom Rule: Replace the reducer cast that uses `any` with concrete reducer-derived types (for state, action, and return) so the test keeps type safety without broad `any` usage. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41252&comment_hash=ac023dd320d7e134042a9f2fe27d659405222f1f12821e98c8ef457baf0592db&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41252&comment_hash=ac023dd320d7e134042a9f2fe27d659405222f1f12821e98c8ef457baf0592db&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
