bito-code-review[bot] commented on code in PR #41252:
URL: https://github.com/apache/superset/pull/41252#discussion_r3445599930
##########
superset-frontend/src/dashboard/reducers/undoableDashboardLayout.ts:
##########
@@ -18,8 +18,8 @@
*/
import { AnyAction, Reducer } from 'redux';
// eslint-disable-next-line import/named
-import undoable, { StateWithHistory } from 'redux-undo';
-import { UNDO_LIMIT } from '../util/constants';
+import undoable, { ActionCreators, StateWithHistory } from 'redux-undo';
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Naming inconsistency with related modules</b></div>
<div id="fix">
Rename the imported `ActionCreators` from 'redux-undo' to
`UndoActionCreators` and update all references (e.g.,
`UndoActionCreators.clearHistory()`) to match the alias used elsewhere in the
dashboard module.
</div>
</div>
<small><i>Code Review Run #9a6e31</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
