rusackas commented on PR #41055: URL: https://github.com/apache/superset/pull/41055#issuecomment-4770729889
Thanks @malon64 - really solid take on a bug that's been biting folks for too long! I traced the preview path through, and the part that actually matters (where_latest_partition falling through to the filtered latest_partition) is covered, so previews should stop injecting those bogus record_count/file_count WHERE clauses. The two-condition gate so we don't clobber a Hive table that happens to have a record_count column is a nice touch too. Only thing in the way is CI - babel-extract is red and the bot's flagging ~997 fuzzy de strings, which is odd for a backend-only change that doesn't touch any translatable strings. Pretty sure that's just a stale branch... I'll see if I can update it now to see if that helps it, but otherwise happy to approve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
