rusackas commented on code in PR #41055:
URL: https://github.com/apache/superset/pull/41055#discussion_r3454152497
##########
superset/db_engine_specs/trino.py:
##########
@@ -631,3 +680,66 @@ def get_indexes(
return super().get_indexes(database, inspector, table)
except NoSuchTableError:
return []
+
+ @classmethod
+ @cache_manager.data_cache.memoize(timeout=60)
+ def latest_partition(
+ cls,
+ database: Database,
+ table: Table,
+ show_first: bool = False,
+ indexes: list[dict[str, Any]] | None = None,
Review Comment:
This one's a false alarm, I think... `latest_partition` is memoized the
exact same way on the base `PrestoBaseEngineSpec` (`presto.py:571`), so Trino
already cached this identically via inheritance before this PR. The override
just mirrors it (and honestly the memoize only got added because CodeAnt
earlier flagged the repeated `get_indexes` call ;)).
It's partition metadata being cached here, not row data. If per-user
isolation of that is genuinely a concern for OAuth2 connections, it'd be
pre-existing and would hit Presto too, so better as its own issue than a
blocker on this Iceberg fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
