pengwk commented on PR #21769:
URL: https://github.com/apache/superset/pull/21769#issuecomment-4770764849
Thanks again for rebasing this. I pushed a small follow-up commit to align
the saved query integration tests with the intended all-query-access behavior
and to fix the export command tests that were failing because the permission
check reads from `superset.security.manager.g`.
Local verification on the updated branch:
```bash
SUPERSET_CONFIG=tests.integration_tests.superset_test_config
SUPERSET_TESTENV=true .venv/bin/python -m pytest \
tests/integration_tests/queries/saved_queries/api_tests.py::TestSavedQueryApi::test_get_list_saved_query
\
tests/integration_tests/queries/saved_queries/api_tests.py::TestSavedQueryApi::test_get_list_sort_saved_query
\
tests/integration_tests/queries/saved_queries/api_tests.py::TestSavedQueryApi::test_get_list_filter_database_saved_query
\
tests/integration_tests/queries/saved_queries/api_tests.py::TestSavedQueryApi::test_get_list_custom_filter_sql_saved_query
\
tests/integration_tests/queries/saved_queries/api_tests.py::TestSavedQueryApi::test_get_list_custom_filter_description_saved_query
\
tests/integration_tests/queries/saved_queries/api_tests.py::TestSavedQueryApi::test_get_saved_query_favorite_filter
\
tests/integration_tests/queries/saved_queries/api_tests.py::TestSavedQueryApi::test_distinct_saved_query
\
tests/integration_tests/queries/saved_queries/commands_tests.py::TestExportSavedQueriesCommand
-q
# 12 passed
```
I also ran changed-file pre-commit successfully for the modified Python
files. Full `pre-commit run --all-files` currently hits an unrelated existing
mypy error in `tests/unit_tests/semantic_layers/mapper_test.py`, outside this
PR's files.
I marked the PR ready for review. The full GitHub Actions workflows are
currently showing `action_required` with no jobs, so they likely need
maintainer approval to run on this fork PR. I also do not have permission to
remove the stale `review:draft` label. Could a maintainer approve the workflows
and remove that label?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
