rusackas commented on PR #21769: URL: https://github.com/apache/superset/pull/21769#issuecomment-4775667106
@pengwk this is a clean fix and thanks for the integration tests. Two small things from the bot review before I merge: the `mock_security_g` param in the commands test looks unused (safe to drop), and the `created_by` filter error path calls `t()` without an `addDangerToast`, so fetch errors fail silently. Mind tidying those two and giving it a rebase? Then I'll merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
