codeant-ai-for-open-source[bot] commented on code in PR #35083:
URL: https://github.com/apache/superset/pull/35083#discussion_r3454506361
##########
tests/integration_tests/reports/api_tests.py:
##########
@@ -2885,3 +2885,93 @@ def
test_dashboard_update_deleted_filter_multiple_reports_notifies_all_owners(
db.session.delete(report_b)
db.session.delete(dashboard)
db.session.commit()
+
+ @patch("superset.tasks.scheduler.execute.apply_async")
+ def test_execute_report_schedule(self, mock_execute):
Review Comment:
**Suggestion:** Add full type hints to this new test method signature by
annotating `mock_execute` and adding an explicit `-> None` return type.
[custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is a newly added Python test method and it lacks both parameter typing
and an explicit return type annotation. The custom rule requires new Python
code to be fully typed, so this is a real violation.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=86557fd000ba4237a3ffa3e4f6104470&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=86557fd000ba4237a3ffa3e4f6104470&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/integration_tests/reports/api_tests.py
**Line:** 2890:2890
**Comment:**
*Custom Rule: Add full type hints to this new test method signature by
annotating `mock_execute` and adding an explicit `-> None` return type.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F35083&comment_hash=d2427a978c8d0314dc82c25b3bc81c0cf42850d6b5c46ab2edd810a73805f928&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F35083&comment_hash=d2427a978c8d0314dc82c25b3bc81c0cf42850d6b5c46ab2edd810a73805f928&reaction=dislike'>👎</a>
##########
tests/integration_tests/reports/api_tests.py:
##########
@@ -2885,3 +2885,93 @@ def
test_dashboard_update_deleted_filter_multiple_reports_notifies_all_owners(
db.session.delete(report_b)
db.session.delete(dashboard)
db.session.commit()
+
+ @patch("superset.tasks.scheduler.execute.apply_async")
+ def test_execute_report_schedule(self, mock_execute):
+ """
+ ReportSchedule Api: Test execute report schedule
+ """
+ report_schedule = (
+ db.session.query(ReportSchedule)
+ .filter(ReportSchedule.name == "name1")
+ .one_or_none()
+ )
+
+ self.login(ADMIN_USERNAME)
+ uri = f"api/v1/report/{report_schedule.id}/execute"
+ rv = self.client.post(uri)
+ assert rv.status_code == 200
+ data = json.loads(rv.data.decode("utf-8"))
+ assert "execution_id" in data
+ assert "message" in data
+ assert data["message"] == "Report schedule execution started
successfully"
+
+ # Verify the task was called
+ mock_execute.assert_called_once()
+ # Verify that the task was called with the correct report_schedule_id
and eta
+ call_args = mock_execute.call_args
+ assert call_args[0][0] == (report_schedule.id,)
+ # Check that eta was set for manual execution
+ assert "eta" in call_args[1]
+ assert call_args[1]["eta"] is not None
+
+ @pytest.mark.usefixtures("create_report_schedules")
+ def test_execute_report_schedule_not_found(self):
+ """
+ ReportSchedule Api: Test execute report schedule not found
+ """
+ self.login(ADMIN_USERNAME)
+ uri = "api/v1/report/9999999/execute"
+ rv = self.client.post(uri)
+ assert rv.status_code == 404
+
+ @pytest.mark.usefixtures("create_report_schedules")
+ def test_execute_report_schedule_not_owned(self):
+ """
+ ReportSchedule Api: Test execute report schedule not owned
+ """
+ report_schedule = (
+ db.session.query(ReportSchedule)
+ .filter(ReportSchedule.name == "name1")
+ .one_or_none()
+ )
+
+ self.login(GAMMA_USERNAME)
+ uri = f"api/v1/report/{report_schedule.id}/execute"
+ rv = self.client.post(uri)
+ assert rv.status_code == 403
+
+ def test_execute_report_schedule_disabled(self):
Review Comment:
**Suggestion:** Add an explicit return type annotation (`-> None`) to this
new method signature to keep new Python code fully typed. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The method is newly added and lacks a return type annotation. Under the
typing rule for new Python code, this is a genuine violation.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=fcea635144374bfabb4c5628aefa2c9e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=fcea635144374bfabb4c5628aefa2c9e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/integration_tests/reports/api_tests.py
**Line:** 2944:2944
**Comment:**
*Custom Rule: Add an explicit return type annotation (`-> None`) to
this new method signature to keep new Python code fully typed.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F35083&comment_hash=0f6857b00f249591feecfa990cba3e5ba364765edfc3bdcad1ae066d25ba54f4&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F35083&comment_hash=0f6857b00f249591feecfa990cba3e5ba364765edfc3bdcad1ae066d25ba54f4&reaction=dislike'>👎</a>
##########
tests/integration_tests/reports/api_tests.py:
##########
@@ -2885,3 +2885,93 @@ def
test_dashboard_update_deleted_filter_multiple_reports_notifies_all_owners(
db.session.delete(report_b)
db.session.delete(dashboard)
db.session.commit()
+
+ @patch("superset.tasks.scheduler.execute.apply_async")
+ def test_execute_report_schedule(self, mock_execute):
+ """
+ ReportSchedule Api: Test execute report schedule
+ """
+ report_schedule = (
+ db.session.query(ReportSchedule)
+ .filter(ReportSchedule.name == "name1")
+ .one_or_none()
+ )
+
+ self.login(ADMIN_USERNAME)
+ uri = f"api/v1/report/{report_schedule.id}/execute"
+ rv = self.client.post(uri)
+ assert rv.status_code == 200
+ data = json.loads(rv.data.decode("utf-8"))
+ assert "execution_id" in data
+ assert "message" in data
+ assert data["message"] == "Report schedule execution started
successfully"
+
+ # Verify the task was called
+ mock_execute.assert_called_once()
+ # Verify that the task was called with the correct report_schedule_id
and eta
+ call_args = mock_execute.call_args
+ assert call_args[0][0] == (report_schedule.id,)
+ # Check that eta was set for manual execution
+ assert "eta" in call_args[1]
+ assert call_args[1]["eta"] is not None
+
+ @pytest.mark.usefixtures("create_report_schedules")
+ def test_execute_report_schedule_not_found(self):
+ """
+ ReportSchedule Api: Test execute report schedule not found
+ """
+ self.login(ADMIN_USERNAME)
+ uri = "api/v1/report/9999999/execute"
+ rv = self.client.post(uri)
+ assert rv.status_code == 404
+
+ @pytest.mark.usefixtures("create_report_schedules")
Review Comment:
**Suggestion:** Add an explicit return type annotation (`-> None`) to this
newly added test method. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is another new Python test method without an explicit return type
annotation. That violates the requirement for fully typed new Python code.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=e1b19ca2618445b98758ccc31139c8b6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=e1b19ca2618445b98758ccc31139c8b6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/integration_tests/reports/api_tests.py
**Line:** 2928:2928
**Comment:**
*Custom Rule: Add an explicit return type annotation (`-> None`) to
this newly added test method.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F35083&comment_hash=4b400d033c6eb7a2e221fb9de88f27660d9ac1235d884c828d42f1053f9dd02a&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F35083&comment_hash=4b400d033c6eb7a2e221fb9de88f27660d9ac1235d884c828d42f1053f9dd02a&reaction=dislike'>👎</a>
##########
tests/integration_tests/reports/api_tests.py:
##########
@@ -2885,3 +2885,93 @@ def
test_dashboard_update_deleted_filter_multiple_reports_notifies_all_owners(
db.session.delete(report_b)
db.session.delete(dashboard)
db.session.commit()
+
+ @patch("superset.tasks.scheduler.execute.apply_async")
+ def test_execute_report_schedule(self, mock_execute):
+ """
+ ReportSchedule Api: Test execute report schedule
+ """
+ report_schedule = (
+ db.session.query(ReportSchedule)
+ .filter(ReportSchedule.name == "name1")
+ .one_or_none()
+ )
+
+ self.login(ADMIN_USERNAME)
+ uri = f"api/v1/report/{report_schedule.id}/execute"
+ rv = self.client.post(uri)
+ assert rv.status_code == 200
+ data = json.loads(rv.data.decode("utf-8"))
+ assert "execution_id" in data
+ assert "message" in data
+ assert data["message"] == "Report schedule execution started
successfully"
+
+ # Verify the task was called
+ mock_execute.assert_called_once()
+ # Verify that the task was called with the correct report_schedule_id
and eta
+ call_args = mock_execute.call_args
+ assert call_args[0][0] == (report_schedule.id,)
+ # Check that eta was set for manual execution
+ assert "eta" in call_args[1]
+ assert call_args[1]["eta"] is not None
+
+ @pytest.mark.usefixtures("create_report_schedules")
+ def test_execute_report_schedule_not_found(self):
Review Comment:
**Suggestion:** Add an explicit return type annotation (`-> None`) to this
newly added test method to satisfy the typing requirement. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This newly introduced test method has no return type annotation. Since the
rule says new Python code should be fully typed, the omission is a valid issue.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=21dbddd830914d34a2e3c330e9eb32e0&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=21dbddd830914d34a2e3c330e9eb32e0&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/integration_tests/reports/api_tests.py
**Line:** 2919:2919
**Comment:**
*Custom Rule: Add an explicit return type annotation (`-> None`) to
this newly added test method to satisfy the typing requirement.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F35083&comment_hash=b0ba8e0a82688b6f267fa3d100b126470d78abd0749d20d9f428b677da094495&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F35083&comment_hash=b0ba8e0a82688b6f267fa3d100b126470d78abd0749d20d9f428b677da094495&reaction=dislike'>👎</a>
##########
tests/integration_tests/reports/api_tests.py:
##########
@@ -2885,3 +2885,93 @@ def
test_dashboard_update_deleted_filter_multiple_reports_notifies_all_owners(
db.session.delete(report_b)
db.session.delete(dashboard)
db.session.commit()
+
+ @patch("superset.tasks.scheduler.execute.apply_async")
+ def test_execute_report_schedule(self, mock_execute):
+ """
+ ReportSchedule Api: Test execute report schedule
+ """
+ report_schedule = (
+ db.session.query(ReportSchedule)
+ .filter(ReportSchedule.name == "name1")
+ .one_or_none()
+ )
+
+ self.login(ADMIN_USERNAME)
+ uri = f"api/v1/report/{report_schedule.id}/execute"
+ rv = self.client.post(uri)
+ assert rv.status_code == 200
+ data = json.loads(rv.data.decode("utf-8"))
+ assert "execution_id" in data
+ assert "message" in data
+ assert data["message"] == "Report schedule execution started
successfully"
+
+ # Verify the task was called
+ mock_execute.assert_called_once()
+ # Verify that the task was called with the correct report_schedule_id
and eta
+ call_args = mock_execute.call_args
+ assert call_args[0][0] == (report_schedule.id,)
+ # Check that eta was set for manual execution
+ assert "eta" in call_args[1]
+ assert call_args[1]["eta"] is not None
+
+ @pytest.mark.usefixtures("create_report_schedules")
+ def test_execute_report_schedule_not_found(self):
+ """
+ ReportSchedule Api: Test execute report schedule not found
+ """
+ self.login(ADMIN_USERNAME)
+ uri = "api/v1/report/9999999/execute"
+ rv = self.client.post(uri)
+ assert rv.status_code == 404
+
+ @pytest.mark.usefixtures("create_report_schedules")
+ def test_execute_report_schedule_not_owned(self):
+ """
+ ReportSchedule Api: Test execute report schedule not owned
+ """
+ report_schedule = (
+ db.session.query(ReportSchedule)
+ .filter(ReportSchedule.name == "name1")
+ .one_or_none()
+ )
+
+ self.login(GAMMA_USERNAME)
+ uri = f"api/v1/report/{report_schedule.id}/execute"
+ rv = self.client.post(uri)
+ assert rv.status_code == 403
+
+ def test_execute_report_schedule_disabled(self):
+ """
+ ReportSchedule Api: Test execute report schedule 404s when feature is
disabled
+ """
+ self.login(ADMIN_USERNAME)
+ with patch("superset.is_feature_enabled", return_value=False):
+ uri = "api/v1/report/1/execute"
+ rv = self.client.post(uri)
+ assert rv.status_code == 404
+
+ @pytest.mark.usefixtures("create_report_schedules")
+ @patch("superset.tasks.scheduler.execute.apply_async")
Review Comment:
**Suggestion:** Add full type hints to this new method signature by
annotating `mock_execute` and adding an explicit `-> None` return type.
[custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This new test method omits both the type for `mock_execute` and the `->
None` return annotation. That matches the custom rule violation for newly added
Python code lacking full type hints.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=934ff346a9aa4869830a879aea65b60a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=934ff346a9aa4869830a879aea65b60a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/integration_tests/reports/api_tests.py
**Line:** 2955:2955
**Comment:**
*Custom Rule: Add full type hints to this new method signature by
annotating `mock_execute` and adding an explicit `-> None` return type.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F35083&comment_hash=a0637d28e5c748b7aa94dae7c9bfd4c7731c5452a40a2931ecde54f770a6d784&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F35083&comment_hash=a0637d28e5c748b7aa94dae7c9bfd4c7731c5452a40a2931ecde54f770a6d784&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
