bito-code-review[bot] commented on code in PR #41285:
URL: https://github.com/apache/superset/pull/41285#discussion_r3455015460
##########
superset-frontend/src/core/sqlLab/models.ts:
##########
@@ -62,6 +65,7 @@ export class Tab implements sqlLabType.Tab {
this.schema = schema;
this.editorGetter = editorGetter;
this.panels = panels;
+ this.backendId = backendId;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing backendId test coverage</b></div>
<div id="fix">
The `backendId` property added to `Tab` class has no test coverage.
sqlLab.test.ts (585 lines) contains zero assertions for backendId — not in
'createTab' (line 560), 'setActiveTab', nor any other test. Per rule [11730],
new features must have unit tests covering success paths, error scenarios, and
edge cases. Add assertions verifying backendId is undefined for new tabs before
sync and properly stored when set via constructor.
</div>
</div>
<small><i>Code Review Run #43c3dc</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
