bito-code-review[bot] commented on code in PR #41285:
URL: https://github.com/apache/superset/pull/41285#discussion_r3455325127
##########
superset-frontend/src/core/sqlLab/models.ts:
##########
@@ -62,6 +65,7 @@ export class Tab implements sqlLabType.Tab {
this.schema = schema;
this.editorGetter = editorGetter;
this.panels = panels;
+ this.backendId = backendId;
Review Comment:
<!-- Bito Reply -->
The suggestion to add test coverage for the `backendId` property is
appropriate. Verifying that `backendId` is undefined for new tabs and correctly
stored when set ensures the property behaves as expected, which improves the
reliability of the `Tab` class.
**superset-frontend/src/core/sqlLab/models.ts**
```
this.schema = schema;
this.editorGetter = editorGetter;
this.panels = panels;
+ this.backendId = backendId;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
