rusackas commented on PR #39231:
URL: https://github.com/apache/superset/pull/39231#issuecomment-4773799294
The a11y attributes look right, thanks @Aitema-gmbh. One thing though:
`FilterBar.test.tsx` was flat `test()` cases and this wraps it all back into a
`describe('FilterBar')` with vaguer names. We're trying to go the other way
([avoid
nesting](https://kentcdodds.com/blog/avoid-nesting-when-youre-testing)). Can we
drop the rewrap and keep that file's changes to just the aria assertions? Also
needs a rebase... holler if help here is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
