rusackas commented on PR #39235:
URL: https://github.com/apache/superset/pull/39235#issuecomment-4773843319
Thanks for grinding through all the bot threads @Aitema-gmbh — and good call
reverting that stray validation code that snuck in (those would've thrown at
render, so 👍). The unitless line-heights and the em switch in SparklineCell are
the right moves for resize.
Two things before I approve/merge:
- The PR description has drifted from the diff — it mentions html {
font-size: 100% }, a rem conversion, and files (UserInfo, Modal, DatabaseModal,
etc.) that aren't in here. Since we squash on merge, mind updating it to
describe what actually shipped (unitless line-heights + token/em font sizes)?
- One open thread left: CustomizationsBadge still uses ${theme.fontSizeSM}px
(and DateFilterLabel similarly). That's a px value via a token, so it won't
scale with the browser's text-size setting. Either make it inherit/em to match
the PR's intent, or just resolve the thread noting it's an intentional theming
swap and zoom covers it.
Once those are sorted and CI's green, happy to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
