rusackas commented on PR #39241:
URL: https://github.com/apache/superset/pull/39241#issuecomment-4773857153
Thanks for working through the earlier notes @Aitema-gmbh, the duplicate
`Filters` and the shared `VisuallyHidden` both look sorted. CI's not green yet
though, and it's the diff this time, not just CI/housekeeping.
`Chart.test.tsx` is failing with "Found multiple elements with the text:
...chart name" - the new sr-only `<h1>{sliceName}>` in `ExploreChartHeader`
renders the slice name a second time, so the `getByText` in that test now
matches twice. Does an `aria-label` on the existing header region get us the
same a11y win without the duplicate text node?
Also `prettier` is red on `DashboardBuilder.tsx`. `pre-commit run prettier`
should clear that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
