rusackas commented on PR #39236: URL: https://github.com/apache/superset/pull/39236#issuecomment-4773865333
Thanks @Aitema-gmbh, this is exactly the opt-in approach I was hoping for, gating SVG behind a flag with canvas as the default. One thing on `config.py`: it's tagged `@lifecycle: production`, but the only valid lifecycles are development/testing/stable/deprecated, and the flag lands in the IN DEVELOPMENT block. Should this be `testing` (or `stable`) and moved to the matching section? Also needs a rebase on current `master` to clear the conflict, then I'm happy to re-review. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
