rusackas commented on PR #39238: URL: https://github.com/apache/superset/pull/39238#issuecomment-4773871027
@Aitema-gmbh thanks for the focus-within fix and for checking before spreading things out. Let's do the spread approach: push the `.ant-input`/`.ant-divider` overrides down into the wrapper components so they stay themable rather than living as global selector overrides. The Echart/RangeFilter/TimeFilter/focus-highlight changes are already in the right spot; it's just the `GlobalStyles` block I'd like to see relocated. One thing I want to make sure of: does `colorTextTertiary` keep its 3:1 margin in dark mode too, or is that ratio you noted white-background only? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
