rusackas commented on PR #37120: URL: https://github.com/apache/superset/pull/37120#issuecomment-4773911313
@Milad93R This PR hasn't really moved since January and a few things from my last pass are still open. CI's red on this PR's own code. `pre-commit run --all-files` locally should clear the formatting ones, and a rebase (it's pretty far behind) will re-run the rest cleanly (I suspect). Still not sure of the mechanism though: `run()` already dedups every yielded filename, so isolated `seen` sets would cause duplicates, not missing files. Can you point at the exact line on master where a chart/db file goes missing? Want to fix the real cause, not reshuffle dedup. Also `seen` is added to `database/export.py` and `theme/export.py` but never read there, and the `query/export.py` change looks unrelated to #37113 — I'd keep the diff to the minimum that fixes the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
