codeant-ai-for-open-source[bot] commented on code in PR #41295:
URL: https://github.com/apache/superset/pull/41295#discussion_r3456194836
##########
tests/integration_tests/security/api_tests.py:
##########
@@ -350,6 +350,30 @@ def test_delete_security_roles_gamma(self):
)
self.assert403(response)
+ def test_show_roles_unexpected_error_returns_generic_message(self):
Review Comment:
**Suggestion:** Add type hints to the new test method signature by
explicitly annotating `self` and the return type so the newly introduced
function is fully typed. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is a newly added Python test method, and its signature has no type
annotations for `self` or the return value. Under the rule that new Python code
should be fully typed, this is a real violation.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=6d4a7fd3efd04276ab2431c688662efc&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=6d4a7fd3efd04276ab2431c688662efc&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/integration_tests/security/api_tests.py
**Line:** 353:353
**Comment:**
*Custom Rule: Add type hints to the new test method signature by
explicitly annotating `self` and the return type so the newly introduced
function is fully typed.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41295&comment_hash=67faa3e595411ad8103dc0ae6365af4c8a264b41a6f49a6ef8f228f3283a0733&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41295&comment_hash=67faa3e595411ad8103dc0ae6365af4c8a264b41a6f49a6ef8f228f3283a0733&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
